Qualcomm AI Engine Direct - Support triu op and linear op with non-constant weights #16014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16014
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 3 PendingAs of commit 52358a1 with merge base 1864fb0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Collaborator
Author
|
Hi @cccclai , When you have some time, could you please review this? |
Collaborator
Author
|
@pytorchbot label "release notes: qualcomm" |
pytorch-bot
bot
added
the
release notes: qualcomm
cccclai
approved these changes
Dec 2, 2025
Contributor
cccclai
left a comment
cccclai
left a comment
There was a problem hiding this comment.
Thanks! Can you rebase so we can test CI? Our CI was disabled for a while
…nstant weights Summary: - Add a pass to decompose triu op during quantization and export stage so that aten.ge.Scalar does not appear after to_edge. - Refactor linear op build to support non-constant weight and bias - Fixed doc - Fixed RMSNorm without eps
shewu-quic
force-pushed
the
dev1/hutton/support_triu
branch
from
ee4023a to
16b9c46
Compare
Collaborator
Author
I have rebased. Thanks. |
AdrianLundell
pushed a commit
to AdrianLundell/executorch
that referenced
this pull request
Dec 2, 2025
…nstant weights (pytorch#16014) Summary: - Add a pass to decompose triu op during quantization and export stage so that aten.ge.Scalar does not appear after to_edge. - Refactor linear op build to support non-constant weight and bias - Fixed typo in doc - Fixed RMSNorm without eps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: